Update k8s package deps to v0.18.8 #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
approved these changes
Aug 19, 2020
| func SupportsDryRun(client discovery.CachedDiscoveryInterface, dynamicClient dynamic.Interface, | ||
| gvk schema.GroupVersionKind) (bool, error) { | ||
| // If an error is returned, DryRun is not supported. | ||
| if err := resource.VerifyDryRun(gvk, dynamicClient, client); err != nil { |
lblackstone
changed the title
The logic for checking if a GVK supports dryRun (server-side diffing) moved, so update that function to use the new library methods.
lblackstone
force-pushed
the
lblackstone/update-k8s-deps
branch
from
e19015f
to
0cdf036
Compare
|
Kustomize test still failing with OOM, but it's unrelated to these changes |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The logic for checking if a GVK supports
dryRun (server-side diffing) moved, so update
that function to use the new library methods.
Related issues (optional)
Related to #1263