Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic with computed values on preview #1368

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

lblackstone
Copy link
Member

Proposed changes

This change fixes a panic introduced in #1355. The panic
occurred in cases where the provider attempted to set the
last applied config annotation with computed values.

Related issues (optional)

Fix #1365

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone lblackstone marked this pull request as ready for review November 10, 2020 00:05
@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

This change fixes a panic introduced in #1355. The panic
occurred in cases where the provider attempted to set the
last applied config annotation with computed values.
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider previews causing panics
2 participants