Error on refresh for an unreachable cluster. #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also related to #416 If the cluster has actually been deleted, we may want to provide a way to force delete the associated resource state that doesn't involve manual editing. |
Previously, the refresh action would assume that an unreachable cluster meant that the resources had been deleted out of band, and would delete them from the state with a warning. This deletion only affected the Pulumi state, not the actual k8s resource, and could be repaired by reverting to the previous checkpoint. Unfortunately, this behavior can lead to unintended state changes in the case of a network partition, especially if the refresh operation is running as part of an automated job. This commit changes the default behavior of refresh to return an error in the case of an unreachable cluster. This change means that the state may have to be updated manually if the cluster was actually deleted, but this seems like a preferable alternative to unexpected state changes.
lblackstone
force-pushed
the
lblackstone/refresh-delete
branch
from
a98f95a
to
a25b654
Compare
viveklak
approved these changes
Apr 12, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, the refresh action would assume that an unreachable
cluster meant that the resources had been deleted out of band,
and would delete them from the state with a warning. This deletion
only affected the Pulumi state, not the actual k8s resource, and
could be repaired by reverting to the previous checkpoint.
Unfortunately, this behavior can lead to unintended state changes
in the case of a network partition, especially if the refresh operation
is running as part of an automated job.
This commit changes the default behavior of refresh to return an
error in the case of an unreachable cluster. This change means that
the state may have to be updated manually if the cluster was actually
deleted, but this seems like a preferable alternative to unexpected
state changes.
Related issues (optional)
Fix #1485