Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support local charts in helm.Release resource #1809

Merged
merged 5 commits into from
Dec 4, 2021
Merged

Support local charts in helm.Release resource #1809

merged 5 commits into from
Dec 4, 2021

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Nov 19, 2021 •
edited
Loading

Proposed changes

Related issues (optional)

Fix #1732

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@alias-rahil
Copy link

alias-rahil commented Dec 1, 2021 •
edited
Loading

Waiting for this to get merged... Any ETA?

@lblackstone
Copy link
Member Author

Waiting for this to get merged... Any ETA?

Yep, I just got back from vacation and will be resuming work on it this week.

@lblackstone lblackstone force-pushed the lblackstone/helm-release-create-fix branch from cf84b19 to d5173a1 Compare December 1, 2021 23:01
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone force-pushed the lblackstone/helm-release-create-fix branch 2 times, most recently from 8330f29 to 54fb2db Compare December 3, 2021 20:54
@lblackstone lblackstone changed the title WIP: refactoring to support local charts Support local charts in helm.Release resource Dec 3, 2021
@lblackstone lblackstone marked this pull request as ready for review December 3, 2021 20:54
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

3 similar comments
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone mentioned this pull request Dec 3, 2021
Merged
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone force-pushed the lblackstone/helm-release-create-fix branch from 86ee565 to 958376a Compare December 3, 2021 22:21
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone merged commit 76b9ef2 into master Dec 4, 2021
@pulumi-bot pulumi-bot deleted the lblackstone/helm-release-create-fix branch December 4, 2021 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveklak viveklak viveklak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Helm/Release] Support local path
3 participants
@lblackstone @alias-rahil @viveklak