-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Helm/Release] [Helm/V3] Add initial support for OCI registries #1892
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Values: rel.Values, | ||
Version: rel.Version, | ||
HelmChartDebug: r.settings.Debug, | ||
IncludeTestHookResources: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside the scope of this PR, but we should probably expose this as an option for users
I'm looking forward to see this PR closed! 💪💪💪 keep rocking |
4f69bcc
to
b1ac94e
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
@viveklak we tried this new support for OCI registries but we were unable to dynamically pass the authentication (username, password). |
Proposed changes
This change adds OCI registry support:
This still needs some OCI specific integration test. This is a little more complicated since we need to provision an OCI registry first.
I followed the following for manually testing this:
gcloud auth configure-docker us-central1-docker.pkg.dev
helm push nginx-6.0.5.tgz oci://us-central1-docker.pkg.dev/pulumi-development/oci
Related issues (optional)
Fixes #1477