-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade k8s client dependencies #2008
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
@viveklak The most interesting part of this change is the removal of our forked memcached discovery client. The upstream library now implements caching, and I verified that the tests took approximately the same amount of time to run, so this doesn't appear to regress performance (as expected). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to add a changelog to document bump of helm and k8s client deps. Also left one comment regarding the cache client change.
- Upgrade helm to v3.9.0 - Upgrade k8s client-go to v0.24.0 - The upstream discovery client now includes caching, so update to the v1.24 implementation. We still need to patch the logging in that client, so reapply the relevant changes on the updated implementation.
9624507
to
787449f
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Proposed changes
Related issues (optional)