Upgrade k8s client dependencies #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
github-actions
bot
added
the
impact/no-changelog-required
|
@viveklak The most interesting part of this change is the removal of our forked memcached discovery client. The upstream library now implements caching, and I verified that the tests took approximately the same amount of time to run, so this doesn't appear to regress performance (as expected). |
viveklak
reviewed
Jun 9, 2022
viveklak
approved these changes
Jun 9, 2022
viveklak
removed
the
impact/no-changelog-required
- Upgrade helm to v3.9.0 - Upgrade k8s client-go to v0.24.0 - The upstream discovery client now includes caching, so update to the v1.24 implementation. We still need to patch the logging in that client, so reapply the relevant changes on the updated implementation.
lblackstone
force-pushed
the
lblackstone/k8s-mods
branch
from
9624507
to
787449f
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
github-actions
bot
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)