Improve local helm chart validation #2410
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. |
L3n41c
force-pushed
the
lenaic/fix_missing_chart
branch
from
0222820
to
e484fa3
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. |
|
/run-acceptance-tests |
|
Please view the PR build: https://github.com/pulumi/pulumi-kubernetes/actions/runs/4995010267 |
|
Hi @L3n41c - thank you for opening this PR! I just saw the issue you opened on its behalf, and I appreciate the diligence you've gone through here. I've approved the tests to run, so will wait on their results for now. |
|
Looks like tests are running successfully, and we have a good changelog entry! Just want to cc: @rquitales as a SME to verify this looks good as well. |
rquitales
changed the title
Chart.yaml file is missing error
There was a problem hiding this comment.
Thanks for your contribution! I think there's still more work to be done to fully close #2409, but this is in the right step and should help solve the current issue you're facing. Approving this PR, and I'll follow-up in the GH Issue about potential next steps we might do to close out #2409.
I've added a comment in #2409 (comment) regarding what I think should also be done. That'll require slightly more work, especially to add more/new test cases. Feel free to add that into this PR if you have capacity - we're more than happy to help point you in the right direction for that.
|
@L3n41c and @rquitales this has broken local charts from See #2426. |
Proposed changes
The
helm.NewRelease(…)function has some logic to look for a local chart before trying to contact a remote registry, even if aRepositoryOpts.Repoparameter has been explicitly provided.This is an issue when the chart we want to create a release from has a name that conflicts with a local folder name.
This change improves the logic and considers a local directory to be a valid chart only if it contains a
Chart.yamlfile.Related issues (optional)
error: Chart.yaml file is missing#2409