Fix chart location logic to work with compressed chart archives #2428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
rquitales
changed the title
|
@rquitales - I can't approve this PR since I opened the initial draft, but it looks like the changes are sound, and I appreciate the extra tests added! Consider this my ✅ |
lblackstone
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
We added more-strict validation logic around chart location in #2410 - this caused a regression for users who use compressed charts via
.tar.gzetc.This PR refactors the file checking logic and ensures that compressed chart archives are correctly handled. 2 additional test cases are also added so the following flows are tested:
Related issues (optional)
Closes: #2426
Closes: #2409