Improve error handling for List resources #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Found 2 breaking changes: |
lblackstone
changed the title
The Namespaced method is used to determine whether a resource is namespace or cluster scoped. The underlying lookup table was out of date and did not include "List" kinds. Fixed both of these issues.
lblackstone
force-pushed
the
lblackstone/is-namespaced
branch
from
313883a
to
09a424c
Compare
thomas11
approved these changes
Jul 14, 2023
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
List resources are included in the SDK for compatibility with various YAML manifests and Helm charts. These resources are not currently able to be created directly, but the failure condition was not handled explicitly. Instead, users would get an error when the provider failed to determine if the resource was namespaced. This is fixed with the following changes: 1. Create a lookup table for known List resources 2. Return an error during Check for List resources with a descriptive error message This change also adds a few missing kinds to the Namespaced lookup table that have been added since the table was created initially.
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
List resources are included in the SDK for compatibility with various YAML manifests and Helm charts. These resources are not currently able to be created directly, but the failure condition was not handled explicitly. Instead, users would get an error when the provider failed to determine if the resource was namespaced. This is fixed with the following changes: 1. Create a lookup table for known List resources 2. Return an error during Check for List resources with a descriptive error message This change also adds a few missing kinds to the Namespaced lookup table that have been added since the table was created initially.
lblackstone
added a commit
that referenced
this pull request
Jul 17, 2023
List resources are included in the SDK for compatibility with various YAML manifests and Helm charts. These resources are not currently able to be created directly, but the failure condition was not handled explicitly. Instead, users would get an error when the provider failed to determine if the resource was namespaced. This is fixed with the following changes: 1. Create a lookup table for known List resources 2. Return an error during Check for List resources with a descriptive error message This change also adds a few missing kinds to the Namespaced lookup table that have been added since the table was created initially.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
List resources are included in the SDK for compatibility with various YAML manifests and Helm charts. These resources are not currently able to be created directly, but the failure condition was not handled explicitly. Instead, users would get an error when the provider failed to determine if the resource was namespaced. This is fixed with the following changes:
This change also adds a few missing kinds to the Namespaced lookup table that have been added since the table was created initially.
Related issues (optional)
Fix #1045
Related to #2494