Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2563: Expose Helm --kube-version argument for contextless diffs #2593

Merged
merged 9 commits into from
Oct 19, 2023

Commits on Oct 3, 2023

  1. pulumi#2563: Expose Helm --kube-version argument for contextless diffs

    <!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
        for Pulumi's contribution guidelines.
    
        Help us merge your changes more quickly by adding more details such
        as labels, milestones, and reviewers.-->
    
    ### Proposed changes
    
    This PR exposes the helm template `--kube-version` argument so it can be manually specified in situations when there is no access to the Kubernetes API server (e.g running a diff in CSA mode with no connection to the cluster).
    
    Prior to this merge:
    * If there were zero k8s contexts --> this field was unset meaning helm would default to some old version (1.20.0 at the time of writing) if it couldn't connect to the k8s context
    * 1+ k8s contexts --> would always try to contact the API server to get the version leading to an error if the API server was unreachable.
    
    This variable will override the behavior in either case, but is mostly useful in the first case or when the context in the second case is malformed / unreachable. 
    
    ### Related issues (optional)
    
    <!--Refer to related PRs or issues: pulumi#1234, or 'Fixes pulumi#1234' or 'Closes pulumi#1234'.
        Or link to full URLs to issues or pull requests in other GitHub repositories. -->
    
    Closes pulumi#2563
    henry-fn committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    844d8c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Configuration menu
    Copy the full SHA
    c7e0fe7 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    c1a320f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    522379d View commit details
    Browse the repository at this point in the history
  3. more tests

    henry-fn committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    0edff0d View commit details
    Browse the repository at this point in the history
  4. make tests more specific

    henry-fn committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    62352b4 View commit details
    Browse the repository at this point in the history
  5. fix version string

    henry-fn committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    19c30b0 View commit details
    Browse the repository at this point in the history
  6. one more fix

    henry-fn committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a18ad7e View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    0a2f9dd View commit details
    Browse the repository at this point in the history