-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2563: Expose Helm --kube-version argument for contextless diffs #2593
Merged
Commits on Oct 3, 2023
-
pulumi#2563: Expose Helm --kube-version argument for contextless diffs
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes This PR exposes the helm template `--kube-version` argument so it can be manually specified in situations when there is no access to the Kubernetes API server (e.g running a diff in CSA mode with no connection to the cluster). Prior to this merge: * If there were zero k8s contexts --> this field was unset meaning helm would default to some old version (1.20.0 at the time of writing) if it couldn't connect to the k8s context * 1+ k8s contexts --> would always try to contact the API server to get the version leading to an error if the API server was unreachable. This variable will override the behavior in either case, but is mostly useful in the first case or when the context in the second case is malformed / unreachable. ### Related issues (optional) <!--Refer to related PRs or issues: pulumi#1234, or 'Fixes pulumi#1234' or 'Closes pulumi#1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. --> Closes pulumi#2563
Configuration menu - View commit details
-
Copy full SHA for 844d8c0 - Browse repository at this point
Copy the full SHA 844d8c0View commit details
Commits on Oct 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c7e0fe7 - Browse repository at this point
Copy the full SHA c7e0fe7View commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c1a320f - Browse repository at this point
Copy the full SHA c1a320fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 522379d - Browse repository at this point
Copy the full SHA 522379dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0edff0d - Browse repository at this point
Copy the full SHA 0edff0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62352b4 - Browse repository at this point
Copy the full SHA 62352b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19c30b0 - Browse repository at this point
Copy the full SHA 19c30b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a18ad7e - Browse repository at this point
Copy the full SHA a18ad7eView commit details
Commits on Oct 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0a2f9dd - Browse repository at this point
Copy the full SHA 0a2f9ddView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.