Retry creation REST calls that fail #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don you have a link to similar logic in |
hausdorff
force-pushed
the
hausdorff/retry
branch
2 times, most recently
from
4f6b393
to
e8b6804
Compare
This commit will introduce a simple retry mechanism that makes the Kubernetes provider more tolerant to misordered resource creation, as is particularly common in Helm and Kubernetes YAML. For example, if Kubernetes YAML specifies to create a `Pod` before the `Namespace` it resides in, it is likely this will cause `pulumi up` to fail. Another example is creating `CustomResoruces` before an operator or controller has the opportunity to register the relevant `CustomResourceDefinition`s. We ameliorate this bug by retrying creation REST calls that fail, with some backoff, and some maximum retry threshold. The effects of this are: * Makes the Kubernetes provider somewhat tolerant to undeclared dependencies between resources. * Makes the Kubernetes provider somewhat tolerant to under-specified CRDs, custom controllers, and custom operators, since the retry logic can stand in for all but the most complex of these (which would still require await logic). This commmit represents major progress towards #240, and should (we believe) fix #239.
hausdorff
force-pushed
the
hausdorff/retry
branch
from
e8b6804
to
0f8d078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will introduce a simple retry mechanism that makes the
Kubernetes provider more tolerant to misordered resource creation, as is
particularly common in Helm and Kubernetes YAML. For example, if
Kubernetes YAML specifies to create a
Podbefore theNamespaceitresides in, it is likely this will cause
pulumi upto fail. Anotherexample is creating
CustomResorucesbefore an operator or controller hasthe opportunity to register the relevant
CustomResourceDefinitions.We ameliorate this bug by retrying creation REST calls that fail, with
some backoff, and some maximum retry threshold. The effects of this are:
dependencies between resources.
CRDs, custom controllers, and custom operators, since the retry logic
can stand in for all but the most complex of these (which would still
require await logic).
This commmit represents major progress towards #240, and should (we
believe) fix #239.