Resource undergoing replacement has incorrect status messages

[EronWright]

Proposed changes

This PR clears the resource status after the awaiter completes, to ensure that the status pertaining to a replacement resource (which would have the same URN) isn't stale.

In this example, the status message is obsolete once the flow hits "created replacement". Before:

 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata];
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be scheduled
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be initialized
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be ready
@ updating....
 ++ kubernetes:core/v1:Pod autonaming-test created replacement (1s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be ready
 +- kubernetes:core/v1:Pod autonaming-test replacing (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be ready
 +- kubernetes:core/v1:Pod autonaming-test replaced (0.00s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be ready
 -- kubernetes:core/v1:Pod autonaming-test deleting original (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be ready
@ updating.....
 -- kubernetes:core/v1:Pod autonaming-test deleted original (1s) [diff: ~metadata]; Waiting for Pod "test-namespace-4d5e71b3/autonaming-test" to be ready

After:

 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata];
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-c74027dd/autonaming-test" to be scheduled
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-c74027dd/autonaming-test" to be initialized
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (0s) [diff: ~metadata]; Waiting for Pod "test-namespace-c74027dd/autonaming-test" to be ready
@ updating....
 ++ kubernetes:core/v1:Pod autonaming-test creating replacement (1s) [diff: ~metadata];
 ++ kubernetes:core/v1:Pod autonaming-test created replacement (1s) [diff: ~metadata];
 +- kubernetes:core/v1:Pod autonaming-test replacing (0s) [diff: ~metadata];
 +- kubernetes:core/v1:Pod autonaming-test replaced (0.00s) [diff: ~metadata];
 -- kubernetes:core/v1:Pod autonaming-test deleting original (0s) [diff: ~metadata];
@ updating.....
 -- kubernetes:core/v1:Pod autonaming-test deleting original (1s) [diff: ~metadata];
 -- kubernetes:core/v1:Pod autonaming-test deleted original (1s) [diff: ~metadata];

Related issues (optional)

Closes #2761

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[codecov]

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (4a5bfcc) 24.72% compared to head (ca19c94) 24.72%.

Files	Patch %	Lines
provider/pkg/await/await.go	9.09%	10 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2810   +/-   ##
=======================================
  Coverage   24.72%   24.72%           
=======================================
  Files          48       48           
  Lines        9647     9651    +4     
=======================================
+ Hits         2385     2386    +1     
- Misses       7106     7109    +3     
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[t0yv0]

Nit: what I've seen at Pulumi before for intentionally ignoring errors is:

err := clearStatus(...)
contract.IgnoreError(err)

[t0yv0]

This is one bit here (and associated return) where it's not immediately obvious to a tired reader that control flow is not changing, and this is just a logging change, however I think that's still the case, it's not changing, localizing error handling to make the code better.. Appreciate eyes on this :)