Create Ingress awaiter with incremental status updates #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lblackstone
changed the title
hausdorff
approved these changes
Nov 20, 2018
pkg/await/extensions_ingress.go
Outdated
| config createAwaitConfig | ||
| ingress *unstructured.Unstructured | ||
| ingressReady bool | ||
| ingressClient *dynamic.ResourceInterface |
There was a problem hiding this comment.
We're doing this because of initializeClient right? I tend to find this awkward. Because we are using the client pool under the covers, it doesn't seem that bad to always just create the client any time that method is called.
pkg/await/extensions_ingress.go
Outdated
| ingressWatcher, endpointWatcher watch.Interface, timeout <-chan time.Time, | ||
| settled chan struct{}, | ||
| ) error { | ||
| iia.config.logStatus(diag.Info, "[1/3] Waiting on endpoints for each Ingress path") |
There was a problem hiding this comment.
In the Service we chose to phrase this along the lines of "service must target pods". I think this is important to keep because many of our users do not know what endpoints are.
|
I did address the feedback, but since it was already approved anyway, and tests are passing, will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287