Update version of 'glob' dependency and remove '@types/glob' to resolve imports conflict #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve imports conflict
rquitales
approved these changes
Mar 1, 2024
rquitales
added
the
impact/no-changelog-required
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2858 +/- ##
=======================================
Coverage 25.46% 25.46%
=======================================
Files 48 48
Lines 7533 7532 -1
=======================================
Hits 1918 1918
+ Misses 5457 5456 -1
Partials 158 158 ☔ View full report in Codecov by Sentry. |
|
I am hitting this exact same bug since last Friday, any chance to cut a release for this soon? |
lumiere-bot bot
added a commit
to coolguy1771/home-ops
that referenced
this pull request
Mar 7, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@pulumi/kubernetes](https://pulumi.com) ([source](https://togithub.com/pulumi/pulumi-kubernetes)) | dependencies | minor | [`4.8.1` -> `4.9.0`](https://renovatebot.com/diffs/npm/@pulumi%2fkubernetes/4.8.1/4.9.0) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>pulumi/pulumi-kubernetes (@​pulumi/kubernetes)</summary> ### [`v4.9.0`](https://togithub.com/pulumi/pulumi-kubernetes/blob/HEAD/CHANGELOG.md#490-March-4-2024) [Compare Source](https://togithub.com/pulumi/pulumi-kubernetes/compare/v4.8.1...v4.9.0) - Fix SSA ignoreChanges by enhancing field manager path comparisons ([pulumi/pulumi-kubernetes#2828) - Update nodejs SDK dependencies ([pulumi/pulumi-kubernetes#2858, [pulumi/pulumi-kubernetes#2861) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMjcuMSIsInVwZGF0ZWRJblZlciI6IjM3LjIyNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulum 1.108.0 and above introduced introduced a nodejs dependency on the arborist packaged witch imports a recent version of the "minimatch" package that exports TS types. We were importing an older version version of glob that does not provider TS types and using "@types/glob" for TS types which imports old types for minimatch.
Updating our dependency on glob to one that exports TS types (and thus does not need the stale @types/glob), resolves the issue.
Fixes #2857