Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helm module into a directory #512

Merged
merged 2 commits into from
Apr 2, 2019
Merged

Conversation

lblackstone
Copy link
Member

The tsdocgen utility works better if module definitions
are split into directories. Move the helm definitions
into a helm/v2 directory, and update the index files
so that the usage doesn't change.

The tsdocgen utility works better if module definitions
are split into directories. Move the helm definitions
into a helm/v2 directory, and update the index files
so that the usage doesn't change.
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but why doesn't git signal that this file has moved? It should if they're identical, right? We should make sure there aren't any changes to the file in the transition.

@lblackstone
Copy link
Member Author

Yeah, I removed the namespace and changed the indentation, so that's probably why git didn't show a move.

@lblackstone lblackstone merged commit 5bb247b into master Apr 2, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/move-helm branch April 2, 2019 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants