Move yaml module into a directory #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hausdorff
reviewed
Apr 1, 2019
There was a problem hiding this comment.
I know we don't do this with other files, but I think it was a mistake: we should probably be copying non-generated .ts files from the templates directory, even if they're not mustache templates. It's just cleaner, it means that when we call make or blow away the generated directory, we know we can re-generate from scratch.
lblackstone
force-pushed
the
lblackstone/move-yaml
branch
from
6f4025c
to
62f761b
Compare
|
That's a good idea, but I'm going to leave that for a separate PR while I continue working on the API docs. |
|
Alright, sounds good, as long as you are aware of the issue, I'm happy! :) |
The tsdocgen utility works better if module definitions are split into directories. Move the yaml definitions into a yaml directory, and update the index files so that the usage doesn't change.
lblackstone
force-pushed
the
lblackstone/move-yaml
branch
from
62f761b
to
4e20270
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tsdocgen utility works better if module definitions
are split into directories. Move the yaml definitions
into a yaml directory, and update the index files
so that the usage doesn't change.
(Based on #512 -- Can ignore the first two commits)