Properly reference override values in Python Helm SDK #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overrides file was being written, but not flushed, so the values were not present during the subsequent helm template step, and were effectively being silently ignored.
lukehoban
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
LGTM
FWIW - I was curious whether either closeing or setting the file to not buffer were better options - but the former apparently doesn't work for NamedTemporaryFiles (it deletes on close by default), and the latter is arguably even more subtle than this fix. TIL.
|
BTW - Do we have test coverage for this? |
metral
approved these changes
Jul 31, 2019
|
|
||
| ### Bug fixes | ||
|
|
||
| - Properly reference override values in Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/676). |
There was a problem hiding this comment.
Suggested change
| - Properly reference override values in Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/676). | |
| - Properly reference override values in Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/676). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overrides file was being written, but not flushed, so the
values were not present during the subsequent helm template
step, and were effectively being silently ignored.
Fixes #675