Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly reference override values in Python Helm SDK #676

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Properly reference override values in Python Helm SDK #676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f360f
Properly reference override values in Python Helm SDK
lblackstone Jul 31, 2019
df4de84
Update python helm test to verify fix
lblackstone Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
## 0.25.4 (Unreleased)

### Supported Kubernetes versions

- v1.15.x
- v1.14.x
- v1.13.x

### Bug fixes

- Properly reference override values in Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/676).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Properly reference override values in Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/676).
- Properly reference override values in Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/676).


## 0.25.3 (July 29, 2019)

### Supported Kubernetes versions
Expand Down
1 change: 1 addition & 0 deletions pkg/gen/python-templates/helm/v2/helm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ def _parse_chart(all_config: Tuple[str, Union[ChartOpts, LocalChartOpts], pulumi
vals = config.values if config.values is not None else {}
data = json.dumps(vals).encode('utf-8')
overrides.write(data)
overrides.flush()

namespace_arg = ['--namespace', config.namespace] if config.namespace else []

Expand Down
1 change: 1 addition & 0 deletions sdk/python/pulumi_kubernetes/helm/v2/helm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ def _parse_chart(all_config: Tuple[str, Union[ChartOpts, LocalChartOpts], pulumi
vals = config.values if config.values is not None else {}
data = json.dumps(vals).encode('utf-8')
overrides.write(data)
overrides.flush()

namespace_arg = ['--namespace', config.namespace] if config.namespace else []

Expand Down