Implement customTimeout for resource deletion #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
approved these changes
Sep 16, 2019
All resources now include a customTimeouts option, but the delete field was previously ignored. Plumb this option through and use the custom timeout if it is set.
lblackstone
force-pushed
the
lblackstone/delete-timeout
branch
from
4ea731c
to
ada9d4b
Compare
|
@metral Good call; updated the relevant SDK docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
All resources now include a customTimeouts option, but
the delete field was previously ignored. Plumb this option
through and use the custom timeout if it is set.
Related issues (optional)
Fixes #746