Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .NET code generation #885

Merged
merged 32 commits into from
Nov 23, 2019
Merged

Add .NET code generation #885

merged 32 commits into from
Nov 23, 2019

Conversation

lukehoban
Copy link
Member

Adds core code-generation support for .NET to the Kubernetes provider.

var pod = new Pulumi.Kubernetes.Core.V1.Pod("pod", new Pod
{
    Spec = new PodSpec
    {
        Containers = 
        {
            new Container
            {
                Name = "nginx",
                Image = "nginx",
            },
        },
    },
});

Part of #863.

@lukehoban
Copy link
Member Author

lukehoban commented Nov 19, 2019

Current build failures are due to the issue in the integration test framework being fixed in pulumi/pulumi#3527.

Fixed with 514f017.

@lukehoban lukehoban changed the title [WIP] Add .NET code generation Add .NET code generation Nov 22, 2019
@lukehoban
Copy link
Member Author

lukehoban commented Nov 22, 2019

@lblackstone @CyrusNajmabadi @mikhailshilkov @hausdorff @pgavlin This now ready for review. Tests are passing for the Guestbook example.

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this coming! I left several small comments.

Makefile Outdated Show resolved Hide resolved
pkg/gen/dotnet-templates/Pulumi.Kubernetes.csproj Outdated Show resolved Hide resolved
pkg/gen/dotnet-templates/Pulumi.Kubernetes.csproj Outdated Show resolved Hide resolved
cmd/pulumi-gen-kubernetes/main.go Show resolved Hide resolved
pkg/gen/dotnet-templates/kind.cs.mustache Outdated Show resolved Hide resolved
pkg/gen/dotnet-templates/kind.cs.mustache Outdated Show resolved Hide resolved
pkg/gen/dotnet-templates/kind.cs.mustache Outdated Show resolved Hide resolved
tests/integration/dotnet/basic/Pulumi.yaml Show resolved Hide resolved
@CyrusNajmabadi
Copy link
Contributor

Skimmed over this and nothing looks out of place or concerning. If you have any particular areas you'd like me to look more deeply at, just call them out. But, otherwise, if this works then this works :)

Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - It looks correct as far as I can tell, but the syntax on the example is pretty hideous. Guessing there's no way around that while maintaining strong typing.

Makefile Outdated Show resolved Hide resolved
sdk/dotnet/Apps/V1/Deployment.cs Show resolved Hide resolved
sdk/dotnet/Apps/V1/Deployment.cs Outdated Show resolved Hide resolved
sdk/nodejs/yaml/yaml.ts Show resolved Hide resolved
tests/integration/dotnet/basic/Program.cs Show resolved Hide resolved
Also pass version information.

Also split tests in two.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants