Move YAML decode logic into provider and improve default Helm namespaces #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reintroduce the reverted changed (#941) from #925 and #934 with a few additional fixes related to the changes in #946. The major changes include the following: - Use a runtime invoke to call a common decodeYaml method in the provider rather than using YAML libraries specific to each language. - Use the namespace parameter of helm.v2.Chart as a default, and set it on known namespace-scoped resources.
lblackstone
force-pushed
the
lblackstone/invoke-yaml-helm
branch
from
489ad79
to
84e8e22
Compare
pgavlin
reviewed
Jan 21, 2020
pgavlin
reviewed
Jan 21, 2020
pgavlin
approved these changes
Jan 21, 2020
1 task
This was referenced Jan 21, 2020
Merged
This was referenced Feb 4, 2020
Open
1 task
This was referenced Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Reintroduce the reverted changed (#941) from #925 and #934 with a few
additional fixes related to the changes in #946.
The major changes include the following:
provider rather than using YAML libraries specific to each language.
and set it on known namespace-scoped resources.
Related issues (optional)
Fixes #217