Improve handling of default namespace for Helm charts #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Done |
lblackstone
force-pushed
the
lblackstone/default-helm-namespace
branch
from
3d98df8
to
c4b4534
Compare
and set it on known namespace-scoped resources.
lblackstone
force-pushed
the
lblackstone/default-helm-namespace
branch
from
725dc06
to
6ab60c9
Compare
metral
approved these changes
Jan 7, 2020
lblackstone
added a commit
that referenced
this pull request
Jan 8, 2020
This reverts commit 2652b10.
lblackstone
added a commit
that referenced
this pull request
Jan 8, 2020
lblackstone
added a commit
that referenced
this pull request
Jan 16, 2020
Reintroduce the reverted changed (#941) from #925 and #934 with a few additional fixes related to the changes in #946. The major changes include the following: - Use a runtime invoke to call a common decodeYaml method in the provider rather than using YAML libraries specific to each language. - Use the namespace parameter of helm.v2.Chart as a default, and set it on known namespace-scoped resources.
lblackstone
added a commit
that referenced
this pull request
Jan 16, 2020
Reintroduce the reverted changed (#941) from #925 and #934 with a few additional fixes related to the changes in #946. The major changes include the following: - Use a runtime invoke to call a common decodeYaml method in the provider rather than using YAML libraries specific to each language. - Use the namespace parameter of helm.v2.Chart as a default, and set it on known namespace-scoped resources.
lblackstone
added a commit
that referenced
this pull request
Jan 21, 2020
…ces (#952) Reintroduce the reverted changed (#941) from #925 and #934 with a few additional fixes related to the changes in #946. The major changes include the following: - Use a runtime invoke to call a common decodeYaml method in the provider rather than using YAML libraries specific to each language. - Use the namespace parameter of helm.v2.Chart as a default, and set it on known namespace-scoped resources.
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use the namespace parameter of helm.v2.Chart as a default,
and set it on known namespace-scoped resources.
TODO:
Add support to other SDKs:
Related issues (optional)
Fixes #217