Handle invalid kubeconfig context #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than immediately returning an error for an invalid kubeconfig context, mark the cluster as unreachable, and only fail with an error on operations that need to talk to the cluster. This will allow invoke methods to operate using the default provider even if no local cluster is configured.
lblackstone
force-pushed
the
lblackstone/handle-bad-context
branch
from
dd9310c
to
7cc0921
Compare
metral
approved these changes
Jan 22, 2020
Open
1 task
This was referenced Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rather than immediately returning an error for an invalid kubeconfig
context, mark the cluster as unreachable, and only fail with an error
on operations that need to talk to the cluster. This will allow invoke
methods to operate using the default provider even if no local cluster
is configured.
Related issues (optional)
Related to #939