-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved error handling for kubeconfig errors #2599
Improved error handling for kubeconfig errors #2599
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov Report
@@ Coverage Diff @@
## eronwright/issue-2486 #2599 +/- ##
=========================================================
- Coverage 18.58% 18.37% -0.22%
=========================================================
Files 47 47
Lines 9609 9610 +1
=========================================================
- Hits 1786 1766 -20
- Misses 7719 7745 +26
+ Partials 104 99 -5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sorry for any confusion about this PR, it was merged into a parent feature branch, see this PR: #2598 |
Proposed changes
This PR tightens the kubeconfig loading logic of the provider.
Errors are not suppressed for the non-default provider (see Handle invalid kubeconfig context #960). The rationale is to stabilize the diff when the inputs are unprocessable, without breaking the invoke use-case.kubeconfig
property is path-like, don't try to parse it as content. This improves the error message.TODO: fix test:
TestSkipUpdateUnreachableFlag
Related issues (optional)