Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to a pre-release upstream using the Plugin Framework #260

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Update to a pre-release upstream using the Plugin Framework #260

merged 5 commits into from
Feb 9, 2023

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Feb 7, 2023 •
edited
Loading

Upstream version: f3a69cbc0904

On top of #263

This is the second attempt to update Random to the latest-greatest pre-release version utilizing the Plugin Framework. The previous attempt had to be rolled back because of #258, but this is now fixed in pf/tfbridge and covered by test in #263.

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Does the PR have any schema changes?

Found 14 breaking changes:
Resource "random:index/randomString:RandomString" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomString:RandomString" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomUuid:RandomUuid" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomUuid:RandomUuid" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomId:RandomId" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomId:RandomId" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomInteger:RandomInteger" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomInteger:RandomInteger" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPassword:RandomPassword" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPassword:RandomPassword" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPet:RandomPet" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPet:RandomPet" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomShuffle:RandomShuffle" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomShuffle:RandomShuffle" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
No new resources/functions.

@t0yv0 t0yv0 changed the base branch from master to t0yv0/test-stack-updates February 9, 2023 00:30
@t0yv0 t0yv0 changed the title Plugin framework Update to a pre-release version using the Plugin Framework Feb 9, 2023
@t0yv0 t0yv0 marked this pull request as ready for review February 9, 2023 00:32
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Does the PR have any schema changes?

Found 14 breaking changes:
Resource "random:index/randomId:RandomId" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomId:RandomId" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomInteger:RandomInteger" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomInteger:RandomInteger" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPassword:RandomPassword" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPassword:RandomPassword" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPet:RandomPet" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomPet:RandomPet" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomShuffle:RandomShuffle" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomShuffle:RandomShuffle" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomString:RandomString" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomString:RandomString" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomUuid:RandomUuid" input "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
Resource "random:index/randomUuid:RandomUuid" output "keepers" additional properties type changed from "pulumi.json#/Any" to "string"
No new resources/functions.

@t0yv0 t0yv0 changed the title Update to a pre-release version using the Plugin Framework Update to a pre-release upstream using the Plugin Framework Feb 9, 2023
iwahbe
iwahbe approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a standard upgrade. Trusting that the bridge is solid, this should be too.

Base automatically changed from t0yv0/test-stack-updates to master February 9, 2023 18:11
@t0yv0
Copy link
Member Author

t0yv0 commented Feb 9, 2023

Trust but verify 🙂

@t0yv0 t0yv0 merged commit e9101f3 into master Feb 9, 2023
@t0yv0 t0yv0 deleted the plugin-framework branch February 9, 2023 18:13
@AaronFriel
Copy link
Member

The "keepers" breaking change is unfortunate.

@t0yv0
Copy link
Member Author

t0yv0 commented Feb 9, 2023

This is the same breaking change we've accepted before. This is an upstream breaking change. I think that programs that use strings there should still be fine.

@lukehoban lukehoban mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazzyfresh jazzyfresh jazzyfresh approved these changes

@iwahbe iwahbe iwahbe approved these changes

@AaronFriel AaronFriel Awaiting requested review from AaronFriel

@guineveresaenger guineveresaenger Awaiting requested review from guineveresaenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t0yv0 @AaronFriel @jazzyfresh @iwahbe