Test that upgrading to the current version is no-change #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
This was referenced Feb 9, 2023
jazzyfresh
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a postmortem on a significant regression #258 this PR introduces a test that verifies that the newly built provider version results in a no-change upgrade. This covers all major resources, and currently only covers TypeScript.
Ideally this kind of test would be trivially expressed in integration.ProgramTest framework but nothing available appears suitable. We should consider merging as-is an then following up with a ticket upstream to request ProgramTest improvements, and finally one day refactor the test to take advantage of the improvements.
I have confirmed that: