-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Props with underscores in ExtraTypes
not translated correctly to camelCase in C# and Typescript
#1786
Comments
Hey @ringods. The In your case, that means changing |
@iwahbe thanks for the feedback. I thought I had to use the Terraform property names. |
You do for |
Can you add this to the docs somewhere? |
Would the docs on the fields |
If you would link from a Markdown file to these sources, I think so. |
What happened?
For the Talos package, I replace a JSON string property with nested types defined in
ExtraTypes
. Some of the types have property names with an underscore. In the generated C# and Typescript SDKs, these properties are not converted to the usual camel cased property names.Example
an ExtraType in resources.go
https://github.com/pulumiverse/pulumi-talos/blob/366f84ccb283fffd12278d52d27765cdfdd8e25f/provider/resources.go#L112-L121
generated C# code
https://github.com/pulumiverse/pulumi-talos/blob/366f84ccb283fffd12278d52d27765cdfdd8e25f/sdk/dotnet/Machine/Inputs/SecretsArgs.cs#L19-L49
https://github.com/pulumiverse/pulumi-talos/blob/366f84ccb283fffd12278d52d27765cdfdd8e25f/sdk/dotnet/Machine/Outputs/SecretsResult.cs#L20-L27
generated Typescript code
https://github.com/pulumiverse/pulumi-talos/blob/366f84ccb283fffd12278d52d27765cdfdd8e25f/sdk/nodejs/types/input.ts#L425-L434
https://github.com/pulumiverse/pulumi-talos/blob/366f84ccb283fffd12278d52d27765cdfdd8e25f/sdk/nodejs/types/output.ts#L292-L301
Output of
pulumi about
N/A. All build dependencies can be seen in https://github.com/pulumiverse/pulumi-talos
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: