Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generation for Python PEP 561 type defs #100

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Conversation

EvanBoyle
Copy link
Contributor

See this PR for pulumi/pulumi https://github.com/pulumi/pulumi/pull/3704/files

We did some work to clean up and enable mypy in pulumi/pulumi in https://github.com/pulumi/pulumi/pull/#3758, and then merged the PR to publish the type spec files.

This PR generates the same py.typed files and required config in setup.py. I tested this on the pulumi-aws package locally. Mypy runs clean on the examples repo, and I was able to solicit some mypy errors:

from pulumi_aws import s33
Evans-MBP:aws-py-s3-folder evanboyle$ mypy __main__.py 
__main__.py:6: error: Module 'pulumi_aws' has no attribute 's33'
__main__.py:8: error: Name 's3' is not defined
__main__.py:16: error: Name 's3' is not defined
__main__.py:37: error: Name 's3' is not defined
Found 4 errors in 1 file (checked 1 source file)

@github-actions
Copy link

Diff for pulumi-vault with commit cd41a34

@github-actions
Copy link

Diff for pulumi-gcp with commit cd41a34

@github-actions
Copy link

Diff for pulumi-azure with commit cd41a34

@github-actions
Copy link

Diff for pulumi-aws with commit cd41a34

Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The diffs look so simple - nice work on this

@EvanBoyle EvanBoyle merged commit 13bc1aa into master Jan 21, 2020
@pulumi-bot pulumi-bot deleted the evan/pythonTypes branch January 21, 2020 20:55
@EvanBoyle
Copy link
Contributor Author

Thanks @stack72. What's the process for releasing these changes and regenerating the downstream libraries?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants