[convert] Ensure not supported lifecycle hook warning become an error #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1803 +/- ##
==========================================
- Coverage 60.60% 60.08% -0.52%
==========================================
Files 303 310 +7
Lines 42348 42731 +383
==========================================
+ Hits 25667 25677 +10
- Misses 15208 15581 +373
Partials 1473 1473 ☔ View full report in Codecov by Sentry. |
iwahbe
approved these changes
Mar 29, 2024
Zaid-Ajaj
deleted the
zaid/ensure-non-supported-lifecycle-hooks-error-out
branch
|
Awesome, thank you! |
Zaid-Ajaj
added a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on pulumi/pulumi-converter-terraform#128 this PR turns warnings into errors when converting examples that have non-supported lifecycle hooks.
Addresses pulumi/pulumi-aws#3482