Revert "[convert] Ensure not supported lifecycle hook warning before … #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an error" This reverts commit 1c48a51.
Zaid-Ajaj
approved these changes
Mar 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1810 +/- ##
==========================================
- Coverage 60.62% 60.08% -0.54%
==========================================
Files 303 310 +7
Lines 42353 42726 +373
==========================================
- Hits 25675 25671 -4
- Misses 15206 15583 +377
Partials 1472 1472 ☔ View full report in Codecov by Sentry. |
Zaid-Ajaj
added a commit
that referenced
this pull request
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…an error"
This reverts commit 1c48a51.
Will get it in after releasing the bridge since downstream tests were run without this commit.