Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross test skip empty lists and strings #1911

Merged
merged 8 commits into from
May 2, 2024
Merged

Cross test skip empty lists and strings #1911

merged 8 commits into from
May 2, 2024

Conversation

VenelinMartinov
Copy link
Contributor

This one adds an escape hatch for empty strings and lists as these are currently broken.

I'll add the tests which repro this in the next PR.

Stacked on #1910

@VenelinMartinov VenelinMartinov changed the title Cross test skip empty Cross test skip empty lists and strings Apr 29, 2024
@VenelinMartinov VenelinMartinov mentioned this pull request Apr 29, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 62.05%. Comparing base (b467adc) to head (ff8e337).

Files Patch % Lines
pkg/tests/cross-tests/rapid_tv_gen.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1911      +/-   ##
==========================================
+ Coverage   60.23%   62.05%   +1.81%     
==========================================
  Files         328      327       -1     
  Lines       44390    36928    -7462     
==========================================
- Hits        26739    22914    -3825     
+ Misses      16152    12515    -3637     
  Partials     1499     1499

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0
Copy link
Member

t0yv0 commented Apr 30, 2024

How are they broken? Examples? This sounds like a pretty severe assertion - I suspect if it was broken this badly we would have more end-user implications so perhaps this is a misunderstanding of the model in some form?

Base automatically changed from vvm/cross_test_max_items to master May 2, 2024 16:13
@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented May 2, 2024 •
edited

I've added the tests in #1913 - wanted to keep the PRs fairly clean and self-contained. I think we get null vs empty wrong in a bunch of places and these are some of them.

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) May 2, 2024 22:56
@VenelinMartinov VenelinMartinov merged commit 0f9ae1a into master May 2, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/cross_test_skip_empty branch May 2, 2024 23:09
VenelinMartinov added a commit that referenced this pull request May 2, 2024
@VenelinMartinov
Cross test input check (#1912)
4f16ef0 
fixes #1792

This adds tests for comparing the inputs passed into the terraform
provider between pulumi and TF.

It also adds a property based test for that.

Stacked on #1911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@iwahbe iwahbe Awaiting requested review from iwahbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VenelinMartinov @t0yv0