Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross test input check #1912

Merged
merged 12 commits into from
May 2, 2024
Merged

Cross test input check #1912

merged 12 commits into from
May 2, 2024

Conversation

VenelinMartinov
Copy link
Contributor

fixes #1792

This adds tests for comparing the inputs passed into the terraform provider between pulumi and TF.

It also adds a property based test for that.

Stacked on #1911

@VenelinMartinov VenelinMartinov mentioned this pull request Apr 29, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 60.19%. Comparing base (b467adc) to head (e3519a0).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/tests/cross-tests/input_check.go 0.00% 70 Missing ⚠️
pkg/tests/cross-tests/rapid_tv_gen.go 0.00% 11 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
- Coverage   60.23%   60.19%   -0.04%     
==========================================
  Files         328      329       +1     
  Lines       44390    44412      +22     
==========================================
- Hits        26739    26736       -3     
- Misses      16152    16177      +25     
  Partials     1499     1499

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

t0yv0
t0yv0 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very aligned with what I sense we need - if we could get a fully rigorous version of this test, the bridge would be in a massively better shape. It would be a great milestone.

Base automatically changed from vvm/cross_test_skip_empty to master May 2, 2024 23:09
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) May 2, 2024 23:10
@VenelinMartinov VenelinMartinov merged commit 4f16ef0 into master May 2, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/cross_test_input_check branch May 2, 2024 23:34
VenelinMartinov added a commit that referenced this pull request May 3, 2024
@VenelinMartinov
Cross test inputs test cases (#1913)
8bf39a6 
This one adds a bunch of test cases which point to discrepancies in the
bridge. Most were generated through the property based tests.

I'll open issues for each one.

Stacked on #1912
@VenelinMartinov VenelinMartinov mentioned this pull request May 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guineveresaenger guineveresaenger guineveresaenger left review comments

@t0yv0 t0yv0 t0yv0 approved these changes

@iwahbe iwahbe Awaiting requested review from iwahbe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross-testing for Inputs
3 participants
@VenelinMartinov @t0yv0 @guineveresaenger