Get skip detailed diff back #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
force-pushed
the
vvm/get_skip_detailed_diff_back
branch
from
b8a7bc0
to
cbec5b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1936 +/- ##
=======================================
Coverage 60.51% 60.52%
=======================================
Files 329 329
Lines 44477 44477
=======================================
+ Hits 26917 26920 +3
+ Misses 16050 16048 -2
+ Partials 1510 1509 -1 ☔ View full report in Codecov by Sentry. |
This was referenced May 8, 2024
guineveresaenger
approved these changes
May 8, 2024
VenelinMartinov
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
May 9, 2024
fixes #1421 by patching the upstream resource to be computed as the provider sets a value for it. This is needed for pulumi/pulumi-terraform-bridge#1936 works around hashicorp/terraform-provider-azurerm#25911 issue for patch: #2015 upstream PR: hashicorp/terraform-provider-azurerm#25912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1934
This is already in GCP and reverting it causes a bunch of test failures.
We need to push it to other providers.
Will address: