Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min pulumi version for python #15

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

ibrasho
Copy link
Contributor

@ibrasho ibrasho commented Aug 15, 2019

$ pulumi-tfgen-github python --overlays overlays/python/ --out sdk/python/

was failing with the following error:

error: failed to generate package: lower version bound must be at least 0.17.28

Not sure when the lower bound was added, but this PR updates the repo to reflect that.

Signed-off-by: Ibrahim AshShohail <me@ibrasho.com>
@ibrasho
Copy link
Contributor Author

ibrasho commented Aug 15, 2019

I'm not sure how the v1.0.0 beta should be handled.

@lukehoban lukehoban requested a review from jen20 August 20, 2019 00:14
@lukehoban lukehoban added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Aug 20, 2019
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I assume we'll want to do a similar change to bump to 1.0.0 once its available.

@lukehoban lukehoban merged commit 2e962ec into pulumi:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants