Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set version as not current on sync #395

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Set version as not current on sync #395

merged 2 commits into from
Nov 2, 2022

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented Nov 2, 2022

We want to set PULUMI_ACCEPT=true to rerun program generation on synced examples in pulumi/pulumi https://github.com/pulumi/pulumi/blob/master/.github/workflows/ci-run-test.yml#L300

@aq17 aq17 requested a review from iwahbe November 2, 2022 21:17
@aq17 aq17 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 2, 2022
iwahbe
iwahbe approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

It would be great to add a note in the PR body saying "This PR was run with PULUMI_ACCEPT=true. You need to manually confirm that changes are valid before accepting.

@aq17 aq17 merged commit 9493c4c into main Nov 2, 2022
@aq17 aq17 deleted the aqiu/fix-sync-workflow branch November 2, 2022 22:07
aq17 added a commit that referenced this pull request Nov 17, 2022
@aq17
Set version as not current on sync (#395)
af71a6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwahbe iwahbe iwahbe approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aq17 @iwahbe