Unable to convert HCL example #11305
Assignees
Labels
area/providers
impact/panic
This bug represents a panic or unexpected crash
kind/bug
Some behavior is incorrect or out of spec
p1
Bugs severe enough to be the next item assigned to an engineer
resolution/fixed
This issue was fixed
Milestone
Comments
dirien
added
kind/bug
|
Here's a stack trace I captured from my reproduction. Regardless of the language, all codegen reliably creates a trace like this (looked at dotnet, go, and node). |
RobbieMcKinstry
added
p1
3 tasks
|
Thanks for submitting this @dirien . My first PR in this area of the codebase, but I think we were just missing a guard. Hopefully its as simple as this. |
bors bot
added a commit
that referenced
this issue
Nov 14, 2022
11311: Guard against empty inputs for objs expressions. r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description `@dirien` raised an issue where tfgen would panic converting PCL under an edge case where an `ObjectExpression` had `nil` arguments. By introducing this guard, we skip annotating the the Object with the type provided by the schema the function in the schema has no args. S/o to `@Zaid-Ajaj` for explaining this code to me and confirming the kill. I was lost without his aid! <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11305 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
|
We're merging a fix for this now. I was able to locally verify correctness. Please let me know if you still encounter this issue after the next release and we can reopen. 👍🏻 |
bors bot
added a commit
that referenced
this issue
Nov 15, 2022
11311: Guard against empty inputs for objs expressions. r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description `@dirien` raised an issue where tfgen would panic converting PCL under an edge case where an `ObjectExpression` had `nil` arguments. By introducing this guard, we skip annotating the the Object with the type provided by the schema the function in the schema has no args. S/o to `@Zaid-Ajaj` for explaining this code to me and confirming the kill. I was lost without his aid! <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11305 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
|
Thanks @RobbieMcKinstry! Will let u know! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
With the latest version of
The provider I'm building is
pulumiverse/pulumi-aquasec.I get following output, when creating the sdks:
See https://github.com/pulumiverse/pulumi-aquasec/actions/runs/3426284456/jobs/5708011242#step:11:236 for more output in the GitHub action.
Steps to reproduce
Run the generation of the sdks in this provider -> https://github.com/pulumiverse/pulumi-aquasec
Expected Behavior
Examples get converted from HCL to the language
Actual Behavior
The example will be dropped from any generated docs or SDKs.
Output of
pulumi aboutAdditional context
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: