Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulumi cli on Windows does not include all vcs and Github tags to Pulumi console #5014

Closed
nicro950 opened this issue Jul 15, 2020 · 0 comments · Fixed by #5406
Closed

Pulumi cli on Windows does not include all vcs and Github tags to Pulumi console #5014

nicro950 opened this issue Jul 15, 2020 · 0 comments · Fixed by #5406
Labels
area/cli UX of using the CLI (args, output, logs) good-first-issue Start here if you'd like to start contributing to Pulumi kind/bug Some behavior is incorrect or out of spec os/windows
Milestone
0.46

Comments

@nicro950
Copy link
Contributor

When running Pulumi commands locally there is a difference between doing so on Windows and Linux. In Linux more tag information is included to Pulumi console. This results in commit information and repo information not being included with the different Pulumi commands losing some information for the different stacks.

These are the tags included on Linux:
image

These are the tags included on Windows:
image
@leezen leezen added area/cli UX of using the CLI (args, output, logs) kind/bug Some behavior is incorrect or out of spec os/windows labels Jul 15, 2020
@leezen leezen added the good-first-issue Start here if you'd like to start contributing to Pulumi label Jul 27, 2020
jetvova added a commit that referenced this issue Sep 18, 2020
@jetvova
Fixed issue #5014 (Missing Pulumi console tags on Windows)
2bd3115 
The existing `path.Join(gitRoot, "..")` function appears to have unexpected behavior on Windows. Instead of appending `..` and returning gitRoot's parent directory,
it replaces the whole string with a single dot. The fix changes the code to instead use `filepath.Dir(gitRoot)`, which correctly returns the parent directory.

This seems to be the only instance in which `path.Join()` is used with `..` in the entire repository. There are some usages of a function called `filepath.Join()`
with dots, but they work correctly.
@justinvp justinvp mentioned this issue Sep 18, 2020
Merged
stack72 added a commit that referenced this issue Sep 25, 2020
@jetvova @stack72
Fixed issue #5014 (Missing Pulumi console tags on Windows) (#5406)
b4c2a35 
Co-authored-by: Paul Stack <public@paulstack.co.uk>
@leezen leezen modified the milestones: current, 0.46 Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cli UX of using the CLI (args, output, logs) good-first-issue Start here if you'd like to start contributing to Pulumi kind/bug Some behavior is incorrect or out of spec os/windows
Projects
None yet
Milestone
0.46
Development

Successfully merging a pull request may close this issue.

Fixed issue #5014 (Missing Pulumi console tags on Windows) pulumi/pulumi
2 participants
@leezen @nicro950