Fixed issue #5014 (Missing Pulumi console tags on Windows) #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing `path.Join(gitRoot, "..")` function appears to have unexpected behavior on Windows. Instead of appending `..` and returning gitRoot's parent directory, it replaces the whole string with a single dot. The fix changes the code to instead use `filepath.Dir(gitRoot)`, which correctly returns the parent directory. This seems to be the only instance in which `path.Join()` is used with `..` in the entire repository. There are some usages of a function called `filepath.Join()` with dots, but they work correctly.
justinvp
added
impact/no-changelog-required
justinvp
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
path.Join(gitRoot, "..")function appears to have unexpected behavior on Windows. Instead of appending..and returning gitRoot's parent directory, it replaces the whole string with a single dot. The fix changes the code to instead usefilepath.Dir(gitRoot), which correctly returns the parent directory.This seems to be the only instance in which
path.Join()is used with..in the entire repository. There are some usages of a function calledfilepath.Join()with dots, but they work correctly.Fixes #5014