Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codegen] Re-enable schema caching for static versioned plugins #10971

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

AaronFriel
Copy link
Contributor

@AaronFriel AaronFriel commented Oct 7, 2022

This condition prevents us from using any caches in ~/.pulumi/plugins, defeating the intent of the cache system. If this is load bearing, will need to determine what the right carve-out is to omit caching behavior.

Resolves #10970

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Oct 7, 2022

Changelog

[uncommitted] (2022-10-13)

Bug Fixes

  • [sdkgen] Re-enables caching the schemas of versioned provider plugins.
    #10971

@AaronFriel AaronFriel requested review from aq17 and iwahbe October 7, 2022 23:22
pkg/codegen/schema/loader.go Outdated Show resolved Hide resolved
pkg/codegen/schema/loader.go Show resolved Hide resolved
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not a great PR for review 😄, but I think the PR is good. LGTM once tests pass. (if there are substantial changes, please ping me again)

P.S. I think we can get non-versioned schemas cached in the future, but this is good for now.

pkg/codegen/schema/loader.go Show resolved Hide resolved
pkg/codegen/testing/test/program_driver.go Show resolved Hide resolved
pkg/codegen/schema/loader.go Show resolved Hide resolved
@AaronFriel
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Oct 13, 2022
10971: [codegen] Re-enable schema caching for static versioned plugins r=AaronFriel a=AaronFriel

This condition prevents us from using any caches in `~/.pulumi/plugins`, defeating the intent of the cache system. If this is load bearing, will need to determine what the right carve-out is to omit caching behavior.

Resolves #10970

Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

Build failed:

@AaronFriel
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

Build succeeded:

@bors bors bot merged commit 2c4318b into master Oct 13, 2022
@pulumi-bot pulumi-bot deleted the friel/enable-versioned-cache branch October 13, 2022 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Performance regression in codegen, cache not used
4 participants