-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[codegen] Re-enable schema caching for static versioned plugins #10971
Conversation
Changelog[uncommitted] (2022-10-13)Bug Fixes
|
407cac3
to
d93383b
Compare
Commit 1 of 2: this makes the changes to every file except the schemas, for ease of review.
…ont'deleted Commit 2 of 2: this modifies schema files in the repository only.
3da4b69
to
1d13201
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not a great PR for review 😄, but I think the PR is good. LGTM once tests pass. (if there are substantial changes, please ping me again)
P.S. I think we can get non-versioned schemas cached in the future, but this is good for now.
bors merge |
10971: [codegen] Re-enable schema caching for static versioned plugins r=AaronFriel a=AaronFriel This condition prevents us from using any caches in `~/.pulumi/plugins`, defeating the intent of the cache system. If this is load bearing, will need to determine what the right carve-out is to omit caching behavior. Resolves #10970 Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
Build failed: |
bors merge |
Build succeeded: |
This condition prevents us from using any caches in
~/.pulumi/plugins
, defeating the intent of the cache system. If this is load bearing, will need to determine what the right carve-out is to omit caching behavior.Resolves #10970