ci: Reduce Windows test parallelism #11249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
added
the
impact/no-changelog-required
AaronFriel
force-pushed
the
friel/test-parallelism-part-39
branch
from
ee21950
to
699a64a
Compare
Changelog[uncommitted] (2022-11-04) |
Frassle
approved these changes
Nov 4, 2022
|
bors merge |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
11250: ci: Move more tests to linux-only integration tests r=AaronFriel a=AaronFriel Reduces the set of smoke tests run on Windows & macOS, balances the reduced parallelism #11249 by moving tests which don't seem to obviously entail cross-platform behavior changes. The tests moved to only run on Linux environments are listed below and except for the first, all were split from `integration_test.go`. * `TestRefreshGo` checks that the Pulumi.yaml `options.refresh` option is obeyed (moved to integration_go_test from integration_go_smoke_test) * `TestStackTagValidation` which tests Pulumi.yaml validation * `TestStackInitValidation` which tests an error on running `pulumi stack init` * `TestConfigPaths` which tests `pulumi config set` under a wide variety of inputs * `TestDestroyStackRef` which tests running `pulumi destroy` on a stack with a large stack reference * `TestJSONOutput` which tests output JSON output diagnostics * `TestExcludeProtected` which tests behavior around marking resources protected * `TestProviderDownloadURL` which tests the `PluginDownloadURL` resource option, but does not actually perform plugin acquisition. These tests either didn't seem to be obviously platform specific or there was a narrower test could verify that parsing and handling the same files worked correctly. As examples of those, the remaining tests that will run on smoke tests (all platforms) are: * `TestConfigSave` which tests `pulumi config set` and stack config parsing * `TestRotatePassphrase` which tests changing the local secrets provider passphrase via stdin - which hypothetically could vary across platforms * `TestJSONOutputWithStreamingPreview` tests streaming output and event capturing * `TestPassphrasePrompting` tests stdin/stdout behavior in prompting for passphrases. Lastly, the `TestProviderDownloadURL` test was modified to ensure we wouldn't make requests to uncontrolled third party URLs. Though the tests don't acquire plugins, we don't control "get.com", so the `.test` TLD is used to ensure test behavior cannot depend on that domain. 11296: Update YAML to 1.0.2 r=AaronFriel a=AaronFriel Co-authored-by: Aaron Friel <mayreply@aaronfriel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases likelihood of CI passing on Windows due to longstanding CPU exhaustion bug on runners. (GitHub support ticket 1791026 on my account.)