ci: Move more tests to linux-only integration tests #11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFriel
force-pushed
the
friel/fewer-tests-on-windows
branch
from
2367325
to
32ebfb0
Compare
Changelog[uncommitted] (2022-11-08) |
AaronFriel
changed the title
AaronFriel
added
the
impact/no-changelog-required
AaronFriel
force-pushed
the
friel/fewer-tests-on-windows
branch
from
32ebfb0
to
28b1ae2
Compare
kpitzen
reviewed
Nov 8, 2022
| @@ -7,10 +7,10 @@ public MyStack() | |||
| // Create an AWS resource (S3 Bucket) | |||
| var r = new Random( | |||
| "default", 10, new ComponentResourceOptions{ | |||
| PluginDownloadURL = "get.com", | |||
| PluginDownloadURL = "get.example.test", | |||
There was a problem hiding this comment.
This applies to other test-content changes, but what's the reason for this change?
There was a problem hiding this comment.
I really don't like it when uncontrolled third party URLs/domain names are in tests. If everything is correctly mocked it's fine, but if not suddenly dev machines & CI are making requests to who-knows-what.
It's even scarier here because these would potentially cause us to download and install a tar.gz file in CI! I checked and that doesn't happen here, but whew, kind of scary.
The IETF reserved .test as a top-level domain that will never be registered or respond to DNS. (Same with .example, .invalid, a few others.)
kpitzen
approved these changes
Nov 9, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the set of smoke tests run on Windows & macOS, balances the reduced parallelism #11249 by moving tests which don't seem to obviously entail cross-platform behavior changes. The tests moved to only run on Linux environments are listed below and except for the first, all were split from
integration_test.go.TestRefreshGochecks that the Pulumi.yamloptions.refreshoption is obeyed (moved to integration_go_test from integration_go_smoke_test)TestStackTagValidationwhich tests Pulumi.yaml validationTestStackInitValidationwhich tests an error on runningpulumi stack initTestConfigPathswhich testspulumi config setunder a wide variety of inputsTestDestroyStackRefwhich tests runningpulumi destroyon a stack with a large stack referenceTestJSONOutputwhich tests output JSON output diagnosticsTestExcludeProtectedwhich tests behavior around marking resources protectedTestProviderDownloadURLwhich tests thePluginDownloadURLresource option, but does not actually perform plugin acquisition.These tests either didn't seem to be obviously platform specific or there was a narrower test could verify that parsing and handling the same files worked correctly. As examples of those, the remaining tests that will run on smoke tests (all platforms) are:
TestConfigSavewhich testspulumi config setand stack config parsingTestRotatePassphrasewhich tests changing the local secrets provider passphrase via stdin - which hypothetically could vary across platformsTestJSONOutputWithStreamingPreviewtests streaming output and event capturingTestPassphrasePromptingtests stdin/stdout behavior in prompting for passphrases.Lastly, the
TestProviderDownloadURLtest was modified to ensure we wouldn't make requests to uncontrolled third party URLs. Though the tests don't acquire plugins, we don't control "get.com", so the.testTLD is used to ensure test behavior cannot depend on that domain.