Switch to a more streamlined view for property diffs. #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like: |
|
Note: we could consider an intra-string diff as well. |
CyrusNajmabadi
commented
Apr 16, 2018
| writeVerbatim(b, deploy.OpUpdate, " => ") | ||
| printPrimitivePropertyValue(b, diff.New, planning, deploy.OpCreate) | ||
| writeVerbatim(b, deploy.OpUpdate, "\n") | ||
| return |
There was a problem hiding this comment.
note: we could consider an instra-string diff as well for if we have "string => string". in the example i provided, it would streamline things even more. However, it would only look good if you were in a terminal and could see colors. otherwise, we'd want to fall back to this display where it was clear what the before/after were.
CyrusNajmabadi
force-pushed
the
propDiff
branch
2 times, most recently
from
bb5fff5
to
72735fa
Compare
CyrusNajmabadi
force-pushed
the
propDiff
branch
from
72735fa
to
fe7b370
Compare
|
Preemptively merging in this fairly simple change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.