cli(state upgrade): Prompt for project names for detached stacks #13078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Changelog[uncommitted] (2023-06-22)Features
|
abhinav
force-pushed
the
filestate-upgrade-backfill-option
branch
from
b07a824
to
85aba26
Compare
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
from
45191c1
to
32f182e
Compare
Frassle
reviewed
Jun 13, 2023
abhinav
added a commit
that referenced
this pull request
Jun 13, 2023
As pointed out in #13078 (comment), we repreatedly reimplement the project name validation logic. This moves it to a central place: `tokens.ValidateProjectName`, and re-uses it in existing places where copies were found.
abhinav
force-pushed
the
filestate-upgrade-backfill-option
branch
from
85aba26
to
d237a3e
Compare
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
2 times, most recently
from
3183a92
to
0224384
Compare
abhinav
added a commit
that referenced
this pull request
Jun 13, 2023
As pointed out in #13078 (comment), we repreatedly reimplement the project name validation logic. This moves it to a central place: `tokens.ValidateProjectName`, and re-uses it in existing places where copies were found.
abhinav
force-pushed
the
filestate-upgrade-backfill-option
branch
from
d237a3e
to
360ea62
Compare
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
from
0224384
to
3433903
Compare
abhinav
added a commit
that referenced
this pull request
Jun 13, 2023
As pointed out in #13078 (comment), we repreatedly reimplement the project name validation logic. This moves it to a central place: `tokens.ValidateProjectName`, and re-uses it in existing places where copies were found.
abhinav
force-pushed
the
filestate-upgrade-backfill-option
branch
from
360ea62
to
3e6cc0d
Compare
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
from
3433903
to
9841557
Compare
abhinav
added a commit
that referenced
this pull request
Jun 13, 2023
As pointed out in #13078 (comment), we repreatedly reimplement the project name validation logic. This moves it to a central place: `tokens.ValidateProjectName`, and re-uses it in existing places where copies were found.
abhinav
force-pushed
the
filestate-upgrade-backfill-option
branch
from
3e6cc0d
to
03ff557
Compare
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
from
9841557
to
23eed33
Compare
bors bot
added a commit
that referenced
this pull request
Jun 13, 2023
13165: sdk/go: Add tokens.ValidateProjectName r=abhinav a=abhinav As pointed out in #13078 (comment), we repreatedly reimplement the project name validation logic. This moves it to a central place: `tokens.ValidateProjectName`, and re-uses it in existing places where copies were found. Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
2 times, most recently
from
5c2a01f
to
c9304ab
Compare
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
3 times, most recently
from
c2c7d4d
to
aa93f5a
Compare
Frassle
approved these changes
Jun 22, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2023
13078: cli(state upgrade): Prompt for project names for detached stacks r=abhinav a=abhinav When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600 --- Preview  Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
|
bors cancel |
|
Canceled. |
|
slightly broken; vt10x library needs an update for Windows. |
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
from
aa93f5a
to
5d39fc9
Compare
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2023
13078: cli(state upgrade): Prompt for project names for detached stacks r=abhinav a=abhinav When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600 --- Preview  13249: fix(codegen/go): Use raw string literals for multiline-strings r=abhinav a=abhinav We already have logic in place to generate mutliline strings with backticks if they meet certain conditions in genTemplateExpression. However, the logic came into effect only if the string was complex enough to warrant use of `Sprintf` because the function short circuits to just printing a string literal if the string doesn't need a `Sprintf`. This changes genStringLiteral to be responsible for the decision of whether the string warrants backticks or not, retaining the prior conditions on whether the string would benefit from being split across multiple lines. Resolves #12358 13252: Freeze v3.73.0 r=Zaid-Ajaj a=Zaid-Ajaj Co-authored-by: Abhinav Gupta <abhinav@pulumi.com> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2023
13078: cli(state upgrade): Prompt for project names for detached stacks r=abhinav a=abhinav When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600 --- Preview  Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600
|
Canceled. |
abhinav
force-pushed
the
abhinav/filestate-upgrade-prompt
branch
from
5d39fc9
to
d5fea17
Compare
|
🤦 I need to skip pty.Open on Windows on the second test too. |
|
bors try |
tryBuild failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2023
13078: cli(state upgrade): Prompt for project names for detached stacks r=abhinav a=abhinav When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600 --- Preview  13254: cli(state/rename): Validate new name before renaming r=abhinav a=abhinav Check that resource names are valid before renaming a resource and possibly corrupting the stack. Resource names are `QName`s, so we rely on tokens.IsQName for this. Resolves #11746 13256: Changelog and go.mod updates for v3.73.0 r=pulumi-bot a=pulumi-bot bors merge Co-authored-by: Abhinav Gupta <abhinav@pulumi.com> Co-authored-by: github-actions <github-actions@github.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2023
13078: cli(state upgrade): Prompt for project names for detached stacks r=abhinav a=abhinav When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600 --- Preview  Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 23, 2023
13078: cli(state upgrade): Prompt for project names for detached stacks r=abhinav a=abhinav When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600 --- Preview  Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
|
Build failed: |
|
setup node timed out: bors retry |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running 'pulumi state upgrade', supply the
ProjectsForDetachedStacks option to the file state backend so that we
get asked to fill in project names for stacks where we could not guess
them automatically.
The implementation of the prompt is straightforward:
For each stack, ask a question with the survey package
and feed the result back to the filestate backend.
Testing this is a bit complicated because terminals are involved.
The test for this uses the go-expect and vt10x libraries
recommended in the documentation for survey.
It uses them to simulate a terminal emulator and acts on the output.
The pty library is used to create a compatible pseduo-terminal.
Unfortunately, these test libraries rely on Unix APIs and are not
available on Windows, so the test will not run on Windows machines.
Resolves #12600
Preview