Freeze v3.73.0 #13252
Merged
Freeze v3.73.0 #13252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaid-Ajaj
added
the
impact/no-changelog-required
dixler
approved these changes
Jun 22, 2023
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2023
13078: cli(state upgrade): Prompt for project names for detached stacks r=abhinav a=abhinav When running 'pulumi state upgrade', supply the ProjectsForDetachedStacks option to the file state backend so that we get asked to fill in project names for stacks where we could not guess them automatically. The implementation of the prompt is straightforward: For each stack, ask a question with the survey package and feed the result back to the filestate backend. Testing this is a bit complicated because terminals are involved. The test for this uses the go-expect and vt10x libraries recommended in the documentation for survey. It uses them to simulate a terminal emulator and acts on the output. The pty library is used to create a compatible pseduo-terminal. Unfortunately, these test libraries rely on Unix APIs and are not available on Windows, so the test will not run on Windows machines. Resolves #12600 --- Preview  13249: fix(codegen/go): Use raw string literals for multiline-strings r=abhinav a=abhinav We already have logic in place to generate mutliline strings with backticks if they meet certain conditions in genTemplateExpression. However, the logic came into effect only if the string was complex enough to warrant use of `Sprintf` because the function short circuits to just printing a string literal if the string doesn't need a `Sprintf`. This changes genStringLiteral to be responsible for the decision of whether the string warrants backticks or not, retaining the prior conditions on whether the string would benefit from being split across multiple lines. Resolves #12358 13252: Freeze v3.73.0 r=Zaid-Ajaj a=Zaid-Ajaj Co-authored-by: Abhinav Gupta <abhinav@pulumi.com> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com>
|
Build failed (retrying...): |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.