Prepare for v3.74.0 release #13322
Merged
Prepare for v3.74.0 release #13322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
added
the
impact/no-changelog-required
abhinav
approved these changes
Jun 29, 2023
|
bors merge |
|
Build failed: |
|
The hosted runner: windows-16core-2022_be37ea1ffd86 lost communication with the server. bors merge p=1 |
|
Build failed:
|
|
bors retry |
|
Unexpected HTTP response: 500 downloading Node bors retry |
|
Already running a review |
|
Build failed: |
|
bors retry |
|
Build failed: |
abhinav
added a commit
that referenced
this pull request
Jun 29, 2023
TestCreatingProjectWithEmptyConfig appears to be broken on master:
```
=== Failed
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (0.00s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (re-run 1) (0.28s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
```
As seen in #13323 and the attempts to land #13322.
To reduce likelihood of "name already exists" errors,
generate a random name for all tests where the name is currently based
on the name of the temporary directory.
Also, change all manually managed temporary directories
(with an unchecked error) to `t.TempDir()` -- making the testing package
handle cleanup of the temporary directories.
bors bot
added a commit
that referenced
this pull request
Jun 29, 2023
13325: test: Attempt to fix TestCreatingProjectWithEmptyConfig r=abhinav a=abhinav
TestCreatingProjectWithEmptyConfig appears to be broken on master:
```
=== Failed
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (0.00s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (re-run 1) (0.28s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
```
As seen in #13323 and the attempts to land #13322.
To reduce likelihood of "name already exists" errors,
generate a random name for all tests where the name is currently based
on the name of the temporary directory.
Also, change all manually managed temporary directories
(with an unchecked error) to `t.TempDir()` -- making the testing package
handle cleanup of the temporary directories.
Note: The randomly generated directory name is used
only in cases where the name of the directory was used as input
in the rest of the test.
Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
abhinav
added a commit
that referenced
this pull request
Jun 29, 2023
TestCreatingProjectWithEmptyConfig appears to be broken on master:
```
=== Failed
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (0.00s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (re-run 1) (0.28s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
```
As seen in #13323 and the attempts to land #13322.
To reduce likelihood of "name already exists" errors,
generate a random name for all tests where the name is currently based
on the name of the temporary directory.
Also, change all manually managed temporary directories
(with an unchecked error) to `t.TempDir()` -- making the testing package
handle cleanup of the temporary directories.
bors bot
added a commit
that referenced
this pull request
Jun 29, 2023
13325: test: Attempt to fix TestCreatingProjectWithEmptyConfig r=abhinav a=abhinav
TestCreatingProjectWithEmptyConfig appears to be broken on master:
```
=== Failed
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (0.00s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
=== FAIL: cmd/pulumi TestCreatingProjectWithEmptyConfig (re-run 1) (0.28s)
new_test.go:330:
Error Trace: /home/runner/work/pulumi/pulumi/pkg/cmd/pulumi/new_test.go:330
Error: Received unexpected error:
A project with this name already exists
Test: TestCreatingProjectWithEmptyConfig
```
As seen in #13323 and the attempts to land #13322.
To reduce likelihood of "name already exists" errors,
generate a random name for all tests where the name is currently based
on the name of the temporary directory.
Also, change all manually managed temporary directories
(with an unchecked error) to `t.TempDir()` -- making the testing package
handle cleanup of the temporary directories.
Note: The randomly generated directory name is used
only in cases where the name of the directory was used as input
in the rest of the test.
Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
|
bors retry |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.