[ci] Handle coverage missing on tests omitted by the retry. #14755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixler
changed the title
dixler
added
the
impact/no-changelog-required
Changelog[uncommitted] (2023-12-07) |
dixler
force-pushed
the
dixler-codecov-rerun-all
branch
17 times, most recently
from
8350d93
to
3cf6df3
Compare
dixler
commented
Dec 6, 2023
pkg/testing/integration/program.go
Outdated
Comment on lines
2202
to
2207
| requirementsPath := filepath.Join(cwd, "requirements.txt") | ||
| requirementsmd5, err := hashFile(requirementsPath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| pt.opts.virtualEnvDir = fmt.Sprintf("pulumi-venv-%x", requirementsmd5) |
There was a problem hiding this comment.
It seems that there's some sort of interaction causing tests to fail in setup when different tests are reading and writing to the same virtualenv.
dixler
force-pushed
the
dixler-codecov-rerun-all
branch
6 times, most recently
from
5146153
to
5449125
Compare
gotestyourself/gotestsum#274 Updates gotestsum to v1.11.0
dixler
force-pushed
the
dixler-codecov-rerun-all
branch
2 times, most recently
from
8f28a68
to
ec921c9
Compare
dixler
force-pushed
the
dixler-codecov-rerun-all
branch
from
ec921c9
to
351a77e
Compare
|
Workaround appears not to work on our setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14756
Due to tests being flakey, they are re-run. The re-runs cause coverage on well-behaved tests to be discarded for the re-run test coverage.
This PR aims to make tests and coverage more reliable.