Temporarily revert validation of urn/id output properties #15025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial temporary revert of 8b26393 (keeping a test that can be kept). The validation is currently preventing the use of `id` as an output property for packaged components (i.e. MLCs), which wasn't originally considered when adding this validation. We do want to be able to support `id` properties for components, so when we do subsequently add back the validation, we'll do so in a way that doesn't prevent that.
3 tasks
Changelog[uncommitted] (2024-01-02)Bug Fixes
|
This was referenced Jan 2, 2024
Test: Upgrade pulumi/{pkg,sdk} to 924eb351442735580aa9410476244c499c2a37fa
pulumi/pulumi-azuread#686
Closed
Closed
Closed
Zaid-Ajaj
approved these changes
Jan 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
Draft changelog:
### Features
- [auto/{go,nodejs,python}] Adds ListEnvironments support to Go, Nodejs
and Python Automation API.
[#14995](#14995)
- [cli/display] Warn correctly about new versions being availablen when
using the CLI dev channel
[#14954](#14954)
### Bug Fixes
- [engine] Fix bug where unimported resources (of different types) with
the same name would cause `--import-file` to panic.
[#15008](#15008)
- [engine] Default parallel operations to a reasonable limit.
- [programgen] Fixes type-annotating nested resource properties when
these have quoted keys
[#15001](#15001)
- [sdkgen] Temporarily revert validation of `urn` and `id` resource
output properties
[#15025](#15025)
- [programgen/{dotnet,python}] Allow object keys to be template
expressions such as static quoted strings
[#15000](#15000)
- [backend/service] Exclude internal events from those sent to Pulumi
Cloud.
[#14972](#14972)
- [sdk/go] fixes fulfillValue error when joining a nil output state
[#14949](#14949)
### Miscellaneous
- [pkg] Upgrade pulumi-java to v0.9.9
[#15007](#15007)
- [yaml] Upgrade yaml to v1.4.5
[#15007](#15007)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
### Features
- [auto/{go,nodejs,python}] Adds ListEnvironments support to Go, Nodejs
and Python Automation API.
[#14995](#14995)
- [cli/display] Warn correctly about new versions being availablen when
using the CLI dev channel
[#14954](#14954)
### Bug Fixes
- [cli/new] Fixes duplicate printing of the AI prompt & answer on
Windows.
- [engine] Fix bug where unimported resources (of different types) with
the same name would cause `--import-file` to panic.
[#15008](#15008)
- [engine] Default parallel operations to a reasonable limit.
[#15016](#15016)
- [programgen] Fixes type-annotating nested resource properties when
these have quoted keys
[#15001](#15001)
- [sdkgen] Temporarily revert validation of `urn` and `id` resource
output properties
[#15025](#15025)
- [programgen/{dotnet,python}] Allow object keys to be template
expressions such as static quoted strings
[#15000](#15000)
- [backend/service] Exclude internal events from those sent to Pulumi
Cloud.
[#14972](#14972)
- [sdk/go] fixes fulfillValue error when joining a nil output state
[#14949](#14949)
### Miscellaneous
- [pkg] Upgrade pulumi-java to v0.9.9
[#15007](#15007)
- [yaml] Upgrade yaml to v1.4.5
[#15007](#15007)
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
…15060) # Description Emits a warning when binding properties of resources if we encounter a property with name `urn` or when we encounter a property with name `id` (only for resources which are not components / MLCs). This is a follow up PR for #15025 ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial temporary revert of 8b26393 (keeping a test that can be kept).
The validation is currently preventing the use of
idas an output property for packaged components (i.e. MLCs), which wasn't originally considered when adding this validation. We do want to be able to supportidproperties for components, so when we do subsequently add back the validation, we'll do so in a way that doesn't prevent that.Part of #15024