[schema] Emit a warning when using id or urn as resource properties #15060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-01-17)Miscellaneous
|
This was referenced Jan 5, 2024
Test: Upgrade pulumi/{pkg,sdk} to 06d270a525ab862e9bb24b693059e7431b708b44
pulumi/pulumi-azuread#694
Closed
Closed
Closed
Closed
justinvp
approved these changes
Jan 5, 2024
|
Also a new test to check that for a component resource |
Zaid-Ajaj
force-pushed
the
zaid/emit-warning-for-id-and-urn
branch
from
6573f85
to
79d96f0
Compare
This was referenced Jan 5, 2024
Test: Upgrade pulumi/{pkg,sdk} to 79d96f0cf67c00508d9fe065fbd331000a6f6fd1
pulumi/pulumi-azuread#697
Closed
Closed
Closed
Closed
Frassle
approved these changes
Jan 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Zaid-Ajaj
force-pushed
the
zaid/emit-warning-for-id-and-urn
branch
from
a4afd2a
to
b2c8e9e
Compare
This was referenced Jan 17, 2024
Closed
Test: Upgrade pulumi/{pkg,sdk} to b2c8e9e053bb05aef78e33daa8dccf2e0243aa4c
pulumi/pulumi-azuread#718
Closed
Closed
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
### Features - [sdk/go] Add WithValue to pulumi.Context [#15149](#15149) ### Bug Fixes - [cli] Fix a panic when user's home directory could not be looked up. [#15160](#15160) - [cli/display] Fix JSON/YAML value diff displays. - [sdk/go] Update github.com/cloudflare/circl to v1.3.7. [#15151](#15151) - [cli/import] --import-file now omits empty resource lists. [#15132](#15132) - [sdk/python] Allow remote components to use output property called id ### Miscellaneous - [sdkgen] Emit a warning when using id or urn as resource outputs [#15060](#15060)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
### Features - [sdk/go] Add WithValue to pulumi.Context [#15149](#15149) ### Bug Fixes - [cli] Fix a panic when user's home directory could not be looked up. [#15160](#15160) - [cli/display] Fix JSON/YAML value diff displays. [#15171](#15171) - [sdk/go] Update github.com/cloudflare/circl to v1.3.7. [#15151](#15151) - [cli/import] --import-file now omits empty resource lists. [#15132](#15132) - [sdk/python] Allow remote components to use output property called id [#15115](#15115) ### Miscellaneous - [sdkgen] Emit a warning when using id or urn as resource outputs [#15060](#15060)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emits a warning when binding properties of resources if we encounter a property with name
urnor when we encounter a property with nameid(only for resources which are not components / MLCs). This is a follow up PR for #15025Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change