Don't omit an empty detailedDiff #15213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-01-22)Bug Fixes
|
Frassle
approved these changes
Jan 22, 2024
justinvp
reviewed
Jan 22, 2024
We have some places where we just have a test that MarshalJSON gives the text we expect. That would probably cover this sufficiently. |
|
@justinvp I validated the fix by ensuring that we now get an empty map in the resOutputEvent when running |
justinvp
approved these changes
Jan 22, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 25, 2024
### Features - [engine] Allow import plugins to define components and logical names. [#15199](#15199) - [cli/display] Incremental improvement on the output when installing plugins [#15201](#15201) - [sdk] Bake the release version into the SDK [#15185](#15185) - [sdk/go] Parse config paths strictly [#15173](#15173) - [cli/new] Adds pulumi:template tag to `pulumi new` created projects [#15056](#15056) - [auto/nodejs] Add new API to install the Pulumi CLI from the Automation API [#14991](#14991) - [sdk/python] Add support for Python 3.12 ### Bug Fixes - [engine] Fix a bug where mapping lookup could sometimes lead to an infinite loop. [#15200](#15200) - [engine] Remove an incorrect assert that resources must have inputs. [#15197](#15197) - [cli/display] Improve output when installing policy packs [#15186](#15186) - [sdk/go] Removes `omitempty` from StepEventMetadata.DetailedDiff [#15213](#15213) - [sdk/go] Replace a deleted type used by Pulumi Cloud code. [#15216](#15216) ### Miscellaneous - [yaml] Upgrade yaml to v1.5.0 [#15214](#15214)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the detailedDiff object is empty, i.e.
{}, it is dropped from the serialized json due to theomitempty. When it is rehydrated on the service, it is rehydrated asnilbecause it is not present in the json object. That causes this line to be passed through and results in an input diff, which leads to the output we see in the cloud of an import showing a lot of changed properties when it should not (See issue for screenshots).Fixes pulumi/pulumi-cloud-requests#339
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change