Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace a type used by the service #15216

Merged
merged 1 commit into from Jan 23, 2024
Merged

Replace a type used by the service #15216

merged 1 commit into from Jan 23, 2024

Conversation

komalali
Copy link
Member

Description

A type that is used by the Pulumi Cloud code was removed in #15028 - this PR replaces it.

Fixes # (issue)

Checklist

  • I have run make tidy to update any new dependencies
  • I have run make lint to verify my code passes the lint check
    • I have formatted my code using gofumpt
  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Jan 23, 2024

Changelog

[uncommitted] (2024-01-23)

Bug Fixes

  • [sdk/go] Replace a deleted type used by Pulumi Cloud code.
    #15216

Copy link
Collaborator

@tgummerer tgummerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about deleting this type when the service was still using it, and thanks for fixing it!

@komalali komalali added this pull request to the merge queue Jan 23, 2024
@komalali komalali removed this pull request from the merge queue due to a manual request Jan 23, 2024
@komalali komalali added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 87d1090 Jan 23, 2024
46 checks passed
@komalali komalali deleted the komal/rename-update branch January 23, 2024 20:22
@justinvp justinvp mentioned this pull request Jan 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 25, 2024
### Features

- [engine] Allow import plugins to define components and logical names.
  [#15199](#15199)

- [cli/display] Incremental improvement on the output when installing
plugins
  [#15201](#15201)

- [sdk] Bake the release version into the SDK
  [#15185](#15185)

- [sdk/go] Parse config paths strictly
  [#15173](#15173)

- [cli/new] Adds pulumi:template tag to `pulumi new` created projects
  [#15056](#15056)

- [auto/nodejs] Add new API to install the Pulumi CLI from the
Automation API
  [#14991](#14991)

- [sdk/python] Add support for Python 3.12


### Bug Fixes

- [engine] Fix a bug where mapping lookup could sometimes lead to an
infinite loop.
  [#15200](#15200)

- [engine] Remove an incorrect assert that resources must have inputs.
  [#15197](#15197)

- [cli/display] Improve output when installing policy packs
  [#15186](#15186)

- [sdk/go] Removes `omitempty` from StepEventMetadata.DetailedDiff
  [#15213](#15213)

- [sdk/go] Replace a deleted type used by Pulumi Cloud code.
  [#15216](#15216)


### Miscellaneous

- [yaml] Upgrade yaml to v1.5.0
  [#15214](#15214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants